Remove Safe checks - #33
Open
JAG-UK wants to merge 1 commit into
Open
Conversation
This was referenced Aug 25, 2026
Author
|
Note this is an alternative to #32 - we can only merge one of these! |
wjmelements
reviewed
Aug 25, 2026
Comment on lines
-35
to
-37
| owner1.isProbablyASafe(); | ||
| owner2.isProbablyASafe(); | ||
|
|
Collaborator
There was a problem hiding this comment.
If we go with this approach, I still want to verify that the owners are contracts. like address.code.length > 0
Author
There was a problem hiding this comment.
Sounds reasonable. Maybe if we land there I could update #32 instead of this one, and put in address.code.length > 0 in addition to or even instead of the multisig owner count calls.
Just because all the check plumbing is still there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to issue #30 this PR removes the Safe check entirely. This reduces testing burden and smart contract weight but does leave a lot of avenues for user error and unrecoverable situations in these important accounts.